| 1 |
On 09/24/2012 03:55 PM, Rick "Zero_Chaos" Farina wrote: |
| 2 |
> That is fantastic thanks. I had most recently submitted this |
| 3 |
> version of the patch which included the ability to add e2fstools |
| 4 |
> optionally instead of always. ryao had been testing for me and |
| 5 |
> found that I messed up somewhere and it was never actually |
| 6 |
> including e2fstools. Anyway I've not had the time recently to find |
| 7 |
> the issue but here is the full patch if you can find the typo it is |
| 8 |
> feature complete if not for the fact that the on/off switch appears |
| 9 |
> to be stuck on off. I tried to copy existing code style but can't |
| 10 |
> honestly say I understood it well. |
| 11 |
|
| 12 |
Patch fixed an applied on master [1]. |
| 13 |
|
| 14 |
If you're curious, the two issues issue were: |
| 15 |
|
| 16 |
* Use of wrong variable: |
| 17 |
- CMD_ZFS=`parse_optbool "$*"` |
| 18 |
+ CMD_E2FSPROGS=`parse_optbool "$*"` |
| 19 |
|
| 20 |
* Missing guard: |
| 21 |
- append_data 'e2fstools' |
| 22 |
+ isTrue "${CMD_E2FSPROGS}" && append_data 'e2fstools' |
| 23 |
|
| 24 |
Best, |
| 25 |
|
| 26 |
|
| 27 |
|
| 28 |
Sebastian |
| 29 |
|
| 30 |
|
| 31 |
[1] |
| 32 |
http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=255c8e84983d5b0285651828938117ba1676802d |
Archives