| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 09/30/2012 03:35 PM, Sebastian Pipping wrote: |
| 5 |
> On 09/24/2012 03:55 PM, Rick "Zero_Chaos" Farina wrote: |
| 6 |
>> That is fantastic thanks. I had most recently submitted this |
| 7 |
>> version of the patch which included the ability to add e2fstools |
| 8 |
>> optionally instead of always. ryao had been testing for me and |
| 9 |
>> found that I messed up somewhere and it was never actually |
| 10 |
>> including e2fstools. Anyway I've not had the time recently to |
| 11 |
>> find the issue but here is the full patch if you can find the |
| 12 |
>> typo it is feature complete if not for the fact that the on/off |
| 13 |
>> switch appears to be stuck on off. I tried to copy existing code |
| 14 |
>> style but can't honestly say I understood it well. |
| 15 |
> |
| 16 |
> Patch fixed an applied on master [1]. |
| 17 |
> |
| 18 |
> If you're curious, the two issues issue were: |
| 19 |
> |
| 20 |
> * Use of wrong variable: - CMD_ZFS=`parse_optbool "$*"` + |
| 21 |
> CMD_E2FSPROGS=`parse_optbool "$*"` |
| 22 |
> |
| 23 |
> * Missing guard: - append_data 'e2fstools' + isTrue |
| 24 |
> "${CMD_E2FSPROGS}" && append_data 'e2fstools' |
| 25 |
|
| 26 |
<3 |
| 27 |
|
| 28 |
thanks, |
| 29 |
Zero |
| 30 |
|
| 31 |
> |
| 32 |
> Best, |
| 33 |
> |
| 34 |
> |
| 35 |
> |
| 36 |
> Sebastian |
| 37 |
> |
| 38 |
> |
| 39 |
> [1] |
| 40 |
> http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=255c8e84983d5b0285651828938117ba1676802d |
| 41 |
> |
| 42 |
> |
| 43 |
> |
| 44 |
|
| 45 |
-----BEGIN PGP SIGNATURE----- |
| 46 |
Version: GnuPG v2.0.19 (GNU/Linux) |
| 47 |
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ |
| 48 |
|
| 49 |
iQIcBAEBAgAGBQJQalITAAoJEKXdFCfdEflKmw8P/0sNvLPasccFI/u7IQ2czbjk |
| 50 |
J6Q6RdEQ6sSuss6zgbJTXpf3g1uqVs4UFexaItbG6K77OtsvYn2gswsx7903dIFD |
| 51 |
KduaUsYo5oACPsn6W3dZyg4Kr1m3MXWe3vKJ1SDA+KOTDBpBuBcTXnAFiEFqU0Nx |
| 52 |
HyFiFAZxPEdPRL28ympCeooQTQO+5UuEvh5nIHQm79IuBOy5BZZsYayhAXFqUTnc |
| 53 |
DlOcjB3tz3CjcVLGCISr2jVfm/v94QvxqHnlHXnJaoQ1j+UneZ+utJDD6QTe7gUD |
| 54 |
B+Lhbuds2qOnImu9pdOORiLStP/N2k+DxZA8KEY5+shu8dEK1U+4F7ehT5gbzCdm |
| 55 |
xsa0KBs2ti71hHI+WqiwEdxaUQb8hAWumNjMb0yr5wt5eluViJDzWehZ+Gmg94BK |
| 56 |
/S+r09T3ZiNSIWjs4oBttRv6RyDvCqi/Tf8do3vz9+IzD0AijqDdi5ja7p47ofsA |
| 57 |
dV0isBgWXF4O/h9pMhVr5gytoJWnW2KTp0GzMqOcIBK7Hqek/wFOf7Srr0gslZDx |
| 58 |
XeW2TQ5Efrle5n7Box3fyXKszYCLbMDGrOfaiw8wyC+8Ei0p8MYWr7cQBCQI/D0M |
| 59 |
MHb0liq7p59Lj7RrqhmCGcVImM10lPF/BKt3pgVu03HjOYesKdS/Zawbpy7Pnl3J |
| 60 |
YKlhwIOVTB08f5/BlBhw |
| 61 |
=Xlli |
| 62 |
-----END PGP SIGNATURE----- |
Archives