1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
On 22-02-12 16:56, Erik Falor wrote: |
5 |
> On Wed, Feb 22, 2012 at 02:26:18PM +0100, Marijn wrote: |
6 |
>> Hi Erik, |
7 |
>> |
8 |
>> you seem to have forgotten to actually attach anything. |
9 |
> |
10 |
> _____ _ _ _ | __ \( ) | | | | | | | |/ ___ | |
11 |
> |__ | | | | | | / _ \| '_ \| | | |__| | | (_) | | | |_| |_____/ |
12 |
> \___/|_| |_(_) |
13 |
> |
14 |
> My bad. |
15 |
> |
16 |
>> Anyway, it is fine if you commit stuff directly to the overlay, |
17 |
>> but it's not a bad idea to also post your patches to the list. |
18 |
> |
19 |
> Let's try this again... |
20 |
|
21 |
Hi Erik, |
22 |
|
23 |
I notice that the SRC_URI contains an explicit version. Ideally we |
24 |
shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV} |
25 |
not accomplish that? |
26 |
|
27 |
I also notice that the ebuild still unsets some variables (A ARCH). I |
28 |
consider it a bug if this is necessary. Have you checked whether it is |
29 |
still necessary? If so what is the state of fixing portage so we don't |
30 |
need to do this unsetting? |
31 |
|
32 |
Otherwise looks good. |
33 |
|
34 |
Marijn |
35 |
|
36 |
-----BEGIN PGP SIGNATURE----- |
37 |
Version: GnuPG v2.0.18 (GNU/Linux) |
38 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
39 |
|
40 |
iEYEARECAAYFAk9GA18ACgkQp/VmCx0OL2wa4gCfQ7QJE95Lc/znjDPrIFhDPorA |
41 |
g7YAn0FbNBfh8FZY2McNrVr+XXUnnF1c |
42 |
=yWTa |
43 |
-----END PGP SIGNATURE----- |