Re: [gentoo-pms] [PATCH] pkg-mgr-commands: Correct 'empty' insopts behavior to match PMs

[Ulrich Mueller]

>>>>> On Fri, 8 Jun 2018, Michał Górny wrote:

> My previous fix to insopts turns out twice wrong: firstly, because I did
> not really type what I meant, and secondly because package managers have
> inconsistent behavior there.  Portage uses the default mode (specified
> by PMS) when insopts was called with no arguments or arguments forming
> an empty string; PkgCore and Paludis literally pass empty argument list
> to install.  Mark the behavior as undefined to match that.
> ---
>  pkg-mgr-commands.tex | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

> diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
> index 01c0c6d..031638a 100644
> --- a/pkg-mgr-commands.tex
> +++ b/pkg-mgr-commands.tex
> @@ -725,9 +725,8 @@ function has returned.
 
>  \item[docinto] As \t{into}, for install subdirectory of \t{dodoc} et al.
>
> -\item[insopts] Takes zero or more arguments, and sets the options passed by \t{doins} et al.\
> -    to the \t{install} command to them. When called with no arguments, resets the option list
> -    to empty.
> +\item[insopts] Takes one or more arguments, and sets the options passed by \t{doins} et al.\
> +    to the \t{install} command to them. Behavior upon encountering empty arguments is undefined.
>
>  \item[diropts] As \t{insopts}, for \t{dodir} et al.
 
LGTM, except for s/Behavior/Behaviour/ because we use the English
spelling throughout (and already fixed my local repo).

Ulrich