Gentoo Archives: gentoo-pms

From: Christian Faulhammer <fauli@g.o>
To: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
Cc: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] EAPI 3 branch could use some reviewing
Date: Sun, 12 Apr 2009 13:31:55
Message-Id: 20090412153126.643a4c28@terra.solaris
In Reply to: [gentoo-pms] EAPI 3 branch could use some reviewing by Ciaran McCreesh

Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>:

> I think I've removed all the TODO items and included everything that's > on the "possible" list for EAPI 3 now. I'd appreciate it if people > could give this a review before I send it to -dev@ and the Council.
As far as I can see the commits are ok, although I wonder if "a use dependency" is correct. I learned at school that "an" is used in front of vowels, though I may have missed the exceptions because of sleeping in class. The explanations of the slot operators are a bit hard to read, maybe rephrasing (and splitting in more sentences) is the way to go here. Also I wonder if doexample and doinclude are good additions, but I have no strong opinion about it. Another thing: You should use \featurelabel not in a separate line but at the beginning of the fist line or at the end of the paragraph you want to mark, currently the margin marks aren't perfect. Something different: I pulled from the eapi-3 branch and made my patches apply on top of it: i) cheat sheet for EAPI 3 ii) pms.cls iii) better page layout They are not ready for shipping and I want to wait for EAPI 3 to settle.
> 725d5ae..1c311de is formatting for the new margin labels thing. > This'll hopefully get modified before we go live with it.
You want the page layout patches beforehand? V-Li -- Christian Faulhammer, Gentoo Lisp project <URL:>, #gentoo-lisp on FreeNode <URL:>


File name MIME type
signature.asc application/pgp-signature


Subject Author
Re: [gentoo-pms] EAPI 3 branch could use some reviewing Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>