Gentoo Archives: gentoo-pms

From: "Michał Górny" <mgorny@g.o>
To: gentoo-pms@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-pms] [PATCH] ebuild-env-vars: Require DISTDIR & FILESDIR to be consistent
Date: Sat, 18 Mar 2017 07:30:50
Message-Id: 20170318073040.16893-1-mgorny@gentoo.org
1 Require both DISTDIR and FILESDIR variables to have consistent value
2 across phases. We need to guarantee that the value used in global scope
3 to propagate PATCHES array will be still valid in src_prepare().
4 Furthermore, as Ulrich Müller points out that PMS requires ebuilds to
5 recalculate any value derived from inconsistent variables, therefore
6 colliding with the global-scope assignment.
7 ---
8 ebuild-env-vars.tex | 4 ++--
9 1 file changed, 2 insertions(+), 2 deletions(-)
10
11 diff --git a/ebuild-env-vars.tex b/ebuild-env-vars.tex
12 index 6b74d90..262bcf9 100644
13 --- a/ebuild-env-vars.tex
14 +++ b/ebuild-env-vars.tex
15 @@ -86,14 +86,14 @@ variable.
16 \t{FILESDIR} &
17 \t{src\_*}, global~scope\footnote{Not necessarily present when installing from a binary package.
18 Ebuilds must not access the directory in global scope.} &
19 - No &
20 + Yes &
21 The full path to a directory where the files from the package's files directory (used for
22 small support files or patches) are available. See section~\ref{sec:package-dirs}. May or may
23 not exist; if a repository provides no support files for the package in question then an ebuild
24 must be prepared for the situation where \t{FILESDIR} points to a non-existent directory. \\
25 \t{DISTDIR} &
26 Ditto &
27 - No &
28 + Yes &
29 The full path to the directory in which the files in the \t{A} variable are stored. \\
30 \t{PORTDIR} &
31 \t{src\_*} &
32 --
33 2.12.0

Replies