| 1 |
On 04/22/2015 04:44 PM, Bertrand Jacquin wrote: |
| 2 |
> On 21/04/2015 01:37, Zac Medico wrote: |
| 3 |
>> On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: |
| 4 |
>>> On 21/04/2015 00:39, Zac Medico wrote: |
| 5 |
>>>> These are in the master branch now: |
| 6 |
>>>> |
| 7 |
>>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 |
| 8 |
>>>> |
| 9 |
>>>> |
| 10 |
>>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169 |
| 11 |
>>>> |
| 12 |
>>>> |
| 13 |
>>> |
| 14 |
>>> Thanks for that :) |
| 15 |
>>> |
| 16 |
>>>> I modified the test as follows in order to ensure that it still works |
| 17 |
>>>> with shell globs: |
| 18 |
>>>> |
| 19 |
>>>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo |
| 20 |
>>>> "${root}"/${no_inst}) ]] ; then |
| 21 |
>>> |
| 22 |
>>> I do not really understand the use case here, do you have an example ? |
| 23 |
>>> |
| 24 |
>>> Cheers, |
| 25 |
>>> |
| 26 |
>> |
| 27 |
>> Well, I don't use INSTALL_MASK myself, so I don't have a real-world |
| 28 |
>> use-case for you. However, it's clear that the code will expand shell |
| 29 |
>> globs, so I preserved that behavior for compatibility. |
| 30 |
> |
| 31 |
> Sorry Zac, I was speaking about the $(echo ..), what does it bring to |
| 32 |
> use it here ? |
| 33 |
> |
| 34 |
> Cheers, |
| 35 |
> |
| 36 |
|
| 37 |
It's a way to check the result of check the result of shell glob |
| 38 |
expansion. The rm call that follows will be subject to identical expansion. |
| 39 |
-- |
| 40 |
Thanks, |
| 41 |
Zac |
Archives