Gentoo Archives: gentoo-portage-dev

From: Bertrand Jacquin <bertrand@×××××××.bzh>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK
Date: Wed, 22 Apr 2015 23:44:27
Message-Id: 5cac28faa26324f08cc2bba6a17583e3@mail.meleeweb.net
In Reply to: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK by Zac Medico
1 On 21/04/2015 01:37, Zac Medico wrote:
2 > On 04/20/2015 05:31 PM, Bertrand Jacquin wrote:
3 >> On 21/04/2015 00:39, Zac Medico wrote:
4 >>> These are in the master branch now:
5 >>>
6 >>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911
7 >>>
8 >>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=e74e2670e3f043608fced9847e54bdbb19f35169
9 >>>
10 >>
11 >> Thanks for that :)
12 >>
13 >>> I modified the test as follows in order to ensure that it still works
14 >>> with shell globs:
15 >>>
16 >>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo
17 >>> "${root}"/${no_inst}) ]] ; then
18 >>
19 >> I do not really understand the use case here, do you have an example ?
20 >>
21 >> Cheers,
22 >>
23 >
24 > Well, I don't use INSTALL_MASK myself, so I don't have a real-world
25 > use-case for you. However, it's clear that the code will expand shell
26 > globs, so I preserved that behavior for compatibility.
27
28 Sorry Zac, I was speaking about the $(echo ..), what does it bring to
29 use it here ?
30
31 Cheers,
32
33 --
34 Bertrand

Replies