Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: alexandru.elisei@×××××.com
Subject: Re: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054)
Date: Sun, 19 Feb 2017 21:12:24
Message-Id: 96ed31b6-d4bc-8079-ce16-a0dc7fda852f@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054) by Alexandru Elisei
1 On 02/19/2017 01:02 PM, Alexandru Elisei wrote:
2 > + valid_repos = []
3 > + missing_sync_type = []
4 > + for repo in selected_repos:
5 > + if repo.sync_type is None:
6 > + missing_sync_type.append(repo.name)
7 > + else:
8 > + valid_repos.append(repo)
9 > + if missing_sync_type:
10 > + msgs.append(warn(" * ") + "Missing sync-type for repo(s): %s" %
11 > + " ".join(missing_sync_type) + "\n")
12 > + return (False, valid_repos, msgs)
13 > +
14 > if auto_sync_only:
15 > - return self._filter_auto(selected_repos)
16 > - return selected_repos
17 > + selected_repos = self._filter_auto(selected_repos)
18
19 Do we support local repos that don't have a sync-uri? If so, what
20 sync-type should be set for such a repo? Is it also necessary to set
21 auto-sync = no, in order to avoid an error for such a repo?
22 --
23 Thanks,
24 Zac

Replies