Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: alexandru.elisei@×××××.com
Subject: Re: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054)
Date: Sun, 19 Feb 2017 21:25:50
Message-Id: 294f1d21-d4b8-5b6b-6d3e-63f79065ba33@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054) by Zac Medico
1 On 02/19/2017 01:12 PM, Zac Medico wrote:
2 > On 02/19/2017 01:02 PM, Alexandru Elisei wrote:
3 >> + valid_repos = []
4 >> + missing_sync_type = []
5 >> + for repo in selected_repos:
6 >> + if repo.sync_type is None:
7 >> + missing_sync_type.append(repo.name)
8 >> + else:
9 >> + valid_repos.append(repo)
10 >> + if missing_sync_type:
11 >> + msgs.append(warn(" * ") + "Missing sync-type for repo(s): %s" %
12 >> + " ".join(missing_sync_type) + "\n")
13 >> + return (False, valid_repos, msgs)
14 >> +
15 >> if auto_sync_only:
16 >> - return self._filter_auto(selected_repos)
17 >> - return selected_repos
18 >> + selected_repos = self._filter_auto(selected_repos)
19 >
20 > Do we support local repos that don't have a sync-uri? If so, what
21 > sync-type should be set for such a repo? Is it also necessary to set
22 > auto-sync = no, in order to avoid an error for such a repo?
23
24 The documentation for sync-type in man/portage.5 says:
25
26 This attribute can be set to empty value to disable synchronization
27 of given repository. Empty value is default.
28
29 From the code, it looks like None is default, which does not give the
30 same behavior as an empty setting.
31 --
32 Thanks,
33 Zac