1 |
On Sun, 1 May 2016 18:38:50 -0700 |
2 |
Brian Dolbec <dolsen@g.o> wrote: |
3 |
|
4 |
> On Sun, 1 May 2016 21:08:47 -0400 |
5 |
> Göktürk Yüksek <gokturk@××××××××××.edu> wrote: |
6 |
> |
7 |
> > Check for: |
8 |
> > - type attribute in <maintainer/> |
9 |
> > - name attribute in <slots/> |
10 |
> > - name attribute in <flag/> |
11 |
> > - type attribute for <remote-id/> |
12 |
> > |
13 |
> > Signed-off-by: Göktürk Yüksek <gokturk@××××××××××.edu> |
14 |
> > --- |
15 |
> > xml-test/missing-attributes/metadata.xml | 23 |
16 |
> > ++++++++++++++++++++++ .../missing-attributes-0.1.ebuild |
17 |
> > | 13 ++++++++++++ 2 files changed, 36 insertions(+) |
18 |
> > create mode 100644 xml-test/missing-attributes/metadata.xml |
19 |
> > create mode 100644 |
20 |
> > xml-test/missing-attributes/missing-attributes-0.1.ebuild |
21 |
> > |
22 |
> > diff --git a/xml-test/missing-attributes/metadata.xml |
23 |
> > b/xml-test/missing-attributes/metadata.xml new file mode 100644 |
24 |
> > index 0000000..cf51afd |
25 |
> > --- /dev/null |
26 |
> > +++ b/xml-test/missing-attributes/metadata.xml |
27 |
> > @@ -0,0 +1,23 @@ |
28 |
> > +<?xml version="1.0" encoding="UTF-8"?> |
29 |
> > +<!DOCTYPE pkgmetadata SYSTEM |
30 |
> > "http://www.gentoo.org/dtd/metadata.dtd"> +<pkgmetadata> |
31 |
> > + <!-- Missing attribute "type" --> |
32 |
> > + <maintainer> |
33 |
> > + <email>foodev@g.o</email> |
34 |
> > + </maintainer> |
35 |
> > + <slots> |
36 |
> > + <!-- Missing attribute "name" --> |
37 |
> > + <slot>Bar slot</slot> |
38 |
> > + </slots> |
39 |
> > + <use> |
40 |
> > + <!-- Missing attribute "name" --> |
41 |
> > + <flag>Baz flag</flag> |
42 |
> > + </use> |
43 |
> > + <upstream> |
44 |
> > + <!-- Missing attribute "type" --> |
45 |
> > + <remote-id>gentoo/gen-b0rk</remote-id> |
46 |
> > + </upstream> |
47 |
> > + <longdescription> |
48 |
> > + Tests for mandatory attributes for various tags |
49 |
> > + </longdescription> |
50 |
> > +</pkgmetadata> |
51 |
> > diff --git |
52 |
> > a/xml-test/missing-attributes/missing-attributes-0.1.ebuild |
53 |
> > b/xml-test/missing-attributes/missing-attributes-0.1.ebuild new file |
54 |
> > mode 100644 index 0000000..5733009 --- /dev/null |
55 |
> > +++ b/xml-test/missing-attributes/missing-attributes-0.1.ebuild |
56 |
> > @@ -0,0 +1,13 @@ |
57 |
> > +# Copyright 1999-2016 Gentoo Foundation |
58 |
> > +# Distributed under the terms of the GNU General Public License v2 |
59 |
> > +# $Id$ |
60 |
> > + |
61 |
> > +EAPI=6 |
62 |
> > + |
63 |
> > +DESCRIPTION="Missing various mandatory attributes in the metadata" |
64 |
> > +HOMEPAGE="https://wiki.gentoo.org/wiki/GLEP:68" |
65 |
> > +SRC_URI="" |
66 |
> > + |
67 |
> > +LICENSE="HPND" |
68 |
> > +SLOT="0" |
69 |
> > +KEYWORDS="~amd64" |
70 |
> |
71 |
> Thank you, push it please :) |
72 |
> |
73 |
|
74 |
Am I getting this correct? There are 4 errors in this metadata.xml? |
75 |
|
76 |
If that is the case, I am getting only 1 error reported for both 2.2.28 |
77 |
and the master branch code. |
78 |
|
79 |
master branch code: |
80 |
|
81 |
brian@professor-x ~/Dev/git/gen-b0rk/xml-test $ repom full |
82 |
|
83 |
RepoMan scours the neighborhood... |
84 |
metadata.bad [fatal] 1 |
85 |
xml-test/missing-attributes/metadata.xml: missing 'name' attribute |
86 |
for 'flag' tag metadata.missing [fatal] 1 |
87 |
xml-test/missing/metadata.xml |
88 |
|
89 |
Note: use --include-dev (-d) to check dependencies for 'dev' profiles |
90 |
|
91 |
Please fix these important QA issues first. |
92 |
RepoMan sez: "Make your QA payment on time and you'll never see the |
93 |
likes of me." |
94 |
|
95 |
|
96 |
|
97 |
Portage-2.2.28 release: |
98 |
|
99 |
brian@professor-x ~/Dev/git/gen-b0rk/xml-test $ repoman full |
100 |
|
101 |
RepoMan scours the neighborhood... |
102 |
metadata.bad [fatal] 1 |
103 |
xml-test/missing-attributes/metadata.xml: missing 'name' attribute |
104 |
for 'flag' tag metadata.missing [fatal] 1 |
105 |
xml-test/missing/metadata.xml |
106 |
|
107 |
Note: use --include-dev (-d) to check dependencies for 'dev' profiles |
108 |
|
109 |
Please fix these important QA issues first. |
110 |
RepoMan sez: "Make your QA payment on time and you'll never see the |
111 |
likes of me." |
112 |
|
113 |
brian@professor-x ~/Dev/git/gen-b0rk/xml-test $ |
114 |
|
115 |
|
116 |
-- |
117 |
Brian Dolbec <dolsen> |