Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] xml-test/missing-attributes: missing mandatory attributes for various tags
Date: Mon, 02 May 2016 01:39:41
Message-Id: 20160501183850.437fd727.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 2/2] xml-test/missing-attributes: missing mandatory attributes for various tags by "Göktürk Yüksek"
1 On Sun, 1 May 2016 21:08:47 -0400
2 Göktürk Yüksek <gokturk@××××××××××.edu> wrote:
3
4 > Check for:
5 > - type attribute in <maintainer/>
6 > - name attribute in <slots/>
7 > - name attribute in <flag/>
8 > - type attribute for <remote-id/>
9 >
10 > Signed-off-by: Göktürk Yüksek <gokturk@××××××××××.edu>
11 > ---
12 > xml-test/missing-attributes/metadata.xml | 23
13 > ++++++++++++++++++++++ .../missing-attributes-0.1.ebuild
14 > | 13 ++++++++++++ 2 files changed, 36 insertions(+)
15 > create mode 100644 xml-test/missing-attributes/metadata.xml
16 > create mode 100644
17 > xml-test/missing-attributes/missing-attributes-0.1.ebuild
18 >
19 > diff --git a/xml-test/missing-attributes/metadata.xml
20 > b/xml-test/missing-attributes/metadata.xml new file mode 100644
21 > index 0000000..cf51afd
22 > --- /dev/null
23 > +++ b/xml-test/missing-attributes/metadata.xml
24 > @@ -0,0 +1,23 @@
25 > +<?xml version="1.0" encoding="UTF-8"?>
26 > +<!DOCTYPE pkgmetadata SYSTEM
27 > "http://www.gentoo.org/dtd/metadata.dtd"> +<pkgmetadata>
28 > + <!-- Missing attribute "type" -->
29 > + <maintainer>
30 > + <email>foodev@g.o</email>
31 > + </maintainer>
32 > + <slots>
33 > + <!-- Missing attribute "name" -->
34 > + <slot>Bar slot</slot>
35 > + </slots>
36 > + <use>
37 > + <!-- Missing attribute "name" -->
38 > + <flag>Baz flag</flag>
39 > + </use>
40 > + <upstream>
41 > + <!-- Missing attribute "type" -->
42 > + <remote-id>gentoo/gen-b0rk</remote-id>
43 > + </upstream>
44 > + <longdescription>
45 > + Tests for mandatory attributes for various tags
46 > + </longdescription>
47 > +</pkgmetadata>
48 > diff --git
49 > a/xml-test/missing-attributes/missing-attributes-0.1.ebuild
50 > b/xml-test/missing-attributes/missing-attributes-0.1.ebuild new file
51 > mode 100644 index 0000000..5733009 --- /dev/null
52 > +++ b/xml-test/missing-attributes/missing-attributes-0.1.ebuild
53 > @@ -0,0 +1,13 @@
54 > +# Copyright 1999-2016 Gentoo Foundation
55 > +# Distributed under the terms of the GNU General Public License v2
56 > +# $Id$
57 > +
58 > +EAPI=6
59 > +
60 > +DESCRIPTION="Missing various mandatory attributes in the metadata"
61 > +HOMEPAGE="https://wiki.gentoo.org/wiki/GLEP:68"
62 > +SRC_URI=""
63 > +
64 > +LICENSE="HPND"
65 > +SLOT="0"
66 > +KEYWORDS="~amd64"
67
68 Thank you, push it please :)
69
70 --
71 Brian Dolbec <dolsen>

Replies