Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/5] rsync: Use gemato routines directly instead of calling the CLI tool
Date: Thu, 01 Feb 2018 20:53:22
Message-Id: 1517518396.16069.0.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 2/5] rsync: Use gemato routines directly instead of calling the CLI tool by Zac Medico
1 W dniu czw, 01.02.2018 o godzinie 12∶50 -0800, użytkownik Zac Medico
2 napisał:
3 > On 02/01/2018 04:17 AM, Michał Górny wrote:
4 > > + except Exception as e:
5 > > + writemsg_level("!!! Manifest verification failed:\n%s\n"
6 > > + % (e,),
7 > > + level=logging.ERROR, noiselevel=-1)
8 > > + exitcode = 1
9 >
10 > If an unexpected exception occurs then this makes it difficult to
11 > diagnose. Maybe use PortageException instead of RuntimeError, and use
12 > traceback.print_exc or portage.util.dump_traceback if an unexpected
13 > exception occurs?
14
15 I was wondering how to handle this case. Hmm... maybe I'll also derive
16 all gemato exceptions from a single one, and catch that. Then we can
17 just let unexpected exceptions explode normally ;-).
18
19 --
20 Best regards,
21 Michał Górny