Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o, "Michał Górny" <mgorny@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH 2/5] rsync: Use gemato routines directly instead of calling the CLI tool | ||
| Date: | Thu, 01 Feb 2018 20:50:15 | ||
| Message-Id: | 97941157-a9b7-0380-f3fa-e546895dfba8@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH 2/5] rsync: Use gemato routines directly instead of calling the CLI tool by "Michał Górny" |
||
| 1 | On 02/01/2018 04:17 AM, Michał Górny wrote: |
| 2 | > + except Exception as e: |
| 3 | > + writemsg_level("!!! Manifest verification failed:\n%s\n" |
| 4 | > + % (e,), |
| 5 | > + level=logging.ERROR, noiselevel=-1) |
| 6 | > + exitcode = 1 |
| 7 | |
| 8 | If an unexpected exception occurs then this makes it difficult to |
| 9 | diagnose. Maybe use PortageException instead of RuntimeError, and use |
| 10 | traceback.print_exc or portage.util.dump_traceback if an unexpected |
| 11 | exception occurs? |
| 12 | -- |
| 13 | Thanks, |
| 14 | Zac |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH 2/5] rsync: Use gemato routines directly instead of calling the CLI tool | "Michał Górny" <mgorny@g.o> |