Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly
Date: Fri, 13 Nov 2015 11:46:41
Message-Id: 5645CD97.2080208@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 11/11/15 22:33, Michał Górny wrote:
5 > Output a warning if LC_CTYPE is set to a value that causes libc
6 > toupper() and/or tolower() conversions not apply correctly to printable
7 > ASCII characters.
8 I think you a verb.
9
10 > + "Please consider enabling another locale (such as " +
11 > + "en_US.UTF-8) in /etc/locale.gen and setting it " +
12 > + "as LC_TYPE in make.conf.")
13 Not sure this is really necessary.
14
15 > + if uc != ruc:
16 > + msg.extend([
17 > + " %s -> %s" % (''.join([chr(x) for x in lc]),
18 > + ''.join([chr(x) for x in ruc])),
19 > + " %28s: %s" % ('expected',
20 > + ''.join([chr(x) for x in uc]))])
21 > + if lc != rlc:
22 > + msg.extend([
23 > + " %s -> %s" % (''.join([chr(x) for x in uc]),
24 > + ''.join([chr(x) for x in rlc])),
25 > + " %28s: %s" % ('expected',
26 > + ''.join([chr(x) for x in lc]))])
27 This is very silly. Even a for loop or list comprehension would be
28 better.
29
30 - --
31 Alexander
32 bernalex@g.o
33 https://secure.plaimi.net/~alexander
34 -----BEGIN PGP SIGNATURE-----
35 Version: GnuPG v2
36
37 iQIcBAEBCgAGBQJWRc2WAAoJENQqWdRUGk8BnRoQAIFLzP1Jn8XIqjUo0H1Q82yz
38 OmY83Qauhh1mR5YBGf23InDWkILjkJVf3N+KLlkZqPNUtbZrueQqjYX9QtpOfqfN
39 7AXPDw6rGXfNS29KXAmCD/Rkw/0c3/9G+g2SASIXFZHh5i850MIcHogyG/oCU1OO
40 QgOsCbiq+i6MpSG1lBk1JKuNXwNWk/uvOJnY0eUZzpqtwR4rxYQYB1bmX2iemkpB
41 EMre3K0spBIgXVAo7ktBgmu5nG0wPGrrufmSJyVbj9hhOtBXBZ+gKgqp3RJltbGG
42 YmwMcCiwBYzf/JRi8wLg4h2YDGxVBHklUYbmZYOVkhVp5P69ylD3EJu4Ju+Cmj/e
43 XGRF1dyQxbxEu9DIaCNFSILgER7kKT0m+Xh4dFQaVziOae9l4O3s8rGBY19fcXWf
44 xj9uya2Mg2GlO60sp0cBKdpi8aAgyuK4OuWazG3J+gFnwEHKcOeDqxg/VacYJRKt
45 LHnoRS4NOMf6SLzMAeQvNMg4xEoimhIVxEA0V1jxERbnNvMNu1goIuB+aooRj+f8
46 8hfvzuwRePKlXZWBxtGa86hJfoCosfNp4jaVbrZUI2KS2LT7rMJg9Xq55mNMF0EQ
47 lgCfAt+Q2vMCpH8oJESka4SnDlVDgqOYZH5FCw253fNgcqwKWDY5VBKFk0Cvn/lI
48 911z7fElFbQ3UCyRL6km
49 =ezqO
50 -----END PGP SIGNATURE-----

Replies