Re: [gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly

[Michał Górny]

On Fri, 13 Nov 2015 12:46:31 +0100
Alexander Berntsen <bernalex@g.o> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 11/11/15 22:33, Michał Górny wrote:
> > Output a warning if LC_CTYPE is set to a value that causes libc
> > toupper() and/or tolower() conversions not apply correctly to printable
> > ASCII characters.
> I think you a verb.
>
> > +					"Please consider enabling another locale (such as " +
> > +					"en_US.UTF-8) in /etc/locale.gen and setting it " +
> > +					"as LC_TYPE in make.conf.")
> Not sure this is really necessary.
>
> > +				if uc != ruc:
> > +					msg.extend([
> > +						"  %s -> %s" % (''.join([chr(x) for x in lc]),
> > +							''.join([chr(x) for x in ruc])),
> > +						"  %28s: %s" % ('expected',
> > +							''.join([chr(x) for x in uc]))])
> > +				if lc != rlc:
> > +					msg.extend([
> > +						"  %s -> %s" % (''.join([chr(x) for x in uc]),
> > +							''.join([chr(x) for x in rlc])),
> > +						"  %28s: %s" % ('expected',
> > +							''.join([chr(x) for x in lc]))])
> This is very silly. Even a for loop or list comprehension would be
> better.

Then please suggest a better one since I don't really understand what
you dislike, nor what you want.

That said, I don't really like this patch. If you can come up with
something better, then please by all means do.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>