| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
If you do drop it, Douglas, I think you should keep it around as a "Warning: |
| 5 |
Deprecated" feature for a while before dropping it outright. |
| 6 |
|
| 7 |
That way the users can give feedback via bugzie and their scripts don't break. |
| 8 |
|
| 9 |
- -Michael |
| 10 |
|
| 11 |
Douglas Anderson wrote: |
| 12 |
> On Sun, Feb 8, 2009 at 3:30 PM, Brian Harring <ferringb@×××××.com> wrote: |
| 13 |
>> patch attached against 0.2.4.2-r1; rough stats follow; |
| 14 |
> [snip] |
| 15 |
>> Mind you this isn't multiple runs, so the numbers are rough |
| 16 |
>> approximations- that said they're fairly representative. |
| 17 |
>> |
| 18 |
>> Strongly suggest y'all keep category support (although I'll keep on |
| 19 |
>> using pquery instead ;). |
| 20 |
>> |
| 21 |
>> Cheers, |
| 22 |
>> ~harring |
| 23 |
>> |
| 24 |
> |
| 25 |
> Heh, OK I was looking at my local version of equery where category |
| 26 |
> filtering IS enabled while I was running tests with old equery, which |
| 27 |
> doesn't have it enabled. Thanks for pointing out my stupid mistake, |
| 28 |
> Brian. :) |
| 29 |
> |
| 30 |
> We can in fact even make it go faster by filtering only cat/pkg before |
| 31 |
> it goes through cp_list: |
| 32 |
> |
| 33 |
> - matches = portage.db["/"]["vartree"].dbapi.cpv_all() |
| 34 |
> + matches = gentoolkit.find_all_installed_packages(lambda x: x.startswith(cat)) |
| 35 |
> |
| 36 |
> But still... why? When is it useful? Clearly it has never been used up |
| 37 |
> until now. |
| 38 |
> |
| 39 |
> So I'm still in favor of just dumping it. Seems like complete |
| 40 |
> superfluous fluff to me. If anyone would have any real-world use for |
| 41 |
> this, I'll clean it up and keep it in. Otherwise I really don't think |
| 42 |
> anyone will miss it (especially not Brian :) ) |
| 43 |
> |
| 44 |
> -Doug |
| 45 |
> |
| 46 |
> P.S. I'm strictly talking about belongs here, category filtering in |
| 47 |
> all other modules (where it's actually useful and makes sense) is not |
| 48 |
> only safe but has been upgraded to take multiple categories, so you |
| 49 |
> can now do: |
| 50 |
> |
| 51 |
> $ ./equery.py l --category=app-portage,sys-apps port |
| 52 |
> [ Searching for port in app-portage, sys-apps ... ] |
| 53 |
> * installed packages |
| 54 |
> [I--] [ ] app-portage/portage-utils-0.1.29 (0) |
| 55 |
> [I--] [ ~] sys-apps/portage-2.2_rc23 (0) |
| 56 |
> |
| 57 |
> |
| 58 |
|
| 59 |
-----BEGIN PGP SIGNATURE----- |
| 60 |
Version: GnuPG v2.0.9 (GNU/Linux) |
| 61 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 62 |
|
| 63 |
iJwEAQECAAYFAkmPBDAACgkQwhlUDnr1of6K6AP/frkkntorPjwHHseoOEK8XzTW |
| 64 |
PcvYXafeuJBlSBcna+RPHkvGJdZe6TBJrohXsDx+eTRNi74rdwjIvcNS0LIOx3oV |
| 65 |
Ttx/M/onA6nk3iw8qOD5AZDUwTnYkY1eLdsR29hJnoGM2CYUoEWYO9TDQ0DiFdeE |
| 66 |
k273HDefsSKxZP43Y/Q= |
| 67 |
=KsaQ |
| 68 |
-----END PGP SIGNATURE----- |
Archives