Re: [gentoo-portage-dev] [PATCH] ArchChecks: don't mix arches between ebuilds

[Brian Dolbec]

On Sun, 24 Apr 2016 08:15:56 +0200
Michał Górny <mgorny@g.o> wrote:

> On Sat, 23 Apr 2016 16:57:21 -0700
> Zac Medico <zmedico@g.o> wrote:
>
> > Fix ArchChecks to not mix arches of ebuilds together, so that
> > errors are only reported for those arches that the ebuild has
> > keywords for.
> > ---
> > Applies to the *repoman* branch.
> >
> >  pym/repoman/modules/scan/arches/arches.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pym/repoman/modules/scan/arches/arches.py
> > b/pym/repoman/modules/scan/arches/arches.py index 4df25a8..6e1c17d
> > 100644 --- a/pym/repoman/modules/scan/arches/arches.py
> > +++ b/pym/repoman/modules/scan/arches/arches.py
> > @@ -69,7 +69,7 @@ class ArchChecks(ScanBase):
> >  				arches.add(('**', '**', ('**',)))
> >  		# update the dynamic data
> >  		dyn_arches = kwargs.get('arches')
> > -		#dyn_arches.clear()
> > +		dyn_arches.clear()
> >  		dyn_arches.update(arches)
>
> Is that some crazy way of replacing contents of an existing dict? May
> be worth a comment since the code looks suspicious, at least.
>

It was an interim step so that modules didn't pass back
arbitrary data to be re-used by other modules after it.  This way
maintains the data pointer to the set (not dict) object in the calling
function. Just assigning it a new set doesn't set the 'arches' pointer
in the calling function so that it can pass that data along to other
modules.

Instead it is getting an extended Future instance from asyncio to hold
the target data.  That also gives it the ability to raise an error if
the data is not set or something tries to set it a second time, etc..

BTW, the code to replace the contents of an existing dictionary is way
crazier...  It has to loop and pop() each item until empty, it does
not have a clear(). Then you can update it with the new contents.

But this step did prove the basic tightened up modules data interface.
And debugged the initial conversion, so I'll be coding the rest of the
conversion in the morning. Then I'll apply your xml patches.
-- 
Brian Dolbec <dolsen>