| 1 |
On Sat, 23 Apr 2016 16:57:21 -0700 |
| 2 |
Zac Medico <zmedico@g.o> wrote: |
| 3 |
|
| 4 |
> Fix ArchChecks to not mix arches of ebuilds together, so that |
| 5 |
> errors are only reported for those arches that the ebuild has |
| 6 |
> keywords for. |
| 7 |
> --- |
| 8 |
> Applies to the *repoman* branch. |
| 9 |
> |
| 10 |
> pym/repoman/modules/scan/arches/arches.py | 2 +- |
| 11 |
> 1 file changed, 1 insertion(+), 1 deletion(-) |
| 12 |
> |
| 13 |
> diff --git a/pym/repoman/modules/scan/arches/arches.py b/pym/repoman/modules/scan/arches/arches.py |
| 14 |
> index 4df25a8..6e1c17d 100644 |
| 15 |
> --- a/pym/repoman/modules/scan/arches/arches.py |
| 16 |
> +++ b/pym/repoman/modules/scan/arches/arches.py |
| 17 |
> @@ -69,7 +69,7 @@ class ArchChecks(ScanBase): |
| 18 |
> arches.add(('**', '**', ('**',))) |
| 19 |
> # update the dynamic data |
| 20 |
> dyn_arches = kwargs.get('arches') |
| 21 |
> - #dyn_arches.clear() |
| 22 |
> + dyn_arches.clear() |
| 23 |
> dyn_arches.update(arches) |
| 24 |
|
| 25 |
Is that some crazy way of replacing contents of an existing dict? May |
| 26 |
be worth a comment since the code looks suspicious, at least. |
| 27 |
|
| 28 |
-- |
| 29 |
Best regards, |
| 30 |
Michał Górny |
| 31 |
<http://dev.gentoo.org/~mgorny/> |
Archives