Gentoo Archives: gentoo-portage-dev

From: Sebastian Luther <SebastianLuther@×××.de>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCHv2] emerge: Don't die when the user has an invalid locale setting
Date: Wed, 06 Aug 2014 21:55:10
Message-Id: 53E2A43B.1050603@gmx.de
In Reply to: [gentoo-portage-dev] [PATCHv2] emerge: Don't die when the user has an invalid locale setting by Mike Gilbert
1 Am 06.08.2014 23:39, schrieb Mike Gilbert:
2 > Resolves bug 519074.
3 > ---
4 > pym/_emerge/main.py | 5 ++++-
5 > 1 file changed, 4 insertions(+), 1 deletion(-)
6 >
7 > diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py
8 > index 1a920f7..52aa9c5 100644
9 > --- a/pym/_emerge/main.py
10 > +++ b/pym/_emerge/main.py
11 > @@ -999,7 +999,10 @@ def emerge_main(args=None):
12 > args = portage._decode_argv(args)
13 >
14 > # Use system locale.
15 > - locale.setlocale(locale.LC_ALL, '')
16 > + try:
17 > + locale.setlocale(locale.LC_ALL, '')
18 > + except locale.Error as e:
19 > + writemsg_level("setlocale: %s\n" % e, level=logging.WARN)
20 >
21 > # Disable color until we're sure that it should be enabled (after
22 > # EMERGE_DEFAULT_OPTS has been parsed).
23 >
24
25 Which locale does it use if this fails? Is it reasonable to continue?

Replies