Gentoo Archives: gentoo-portage-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCHv2] emerge: Don't die when the user has an invalid locale setting
Date: Wed, 06 Aug 2014 22:20:30
Message-Id: CAJ0EP42m06wkcDCQ6qzzuQ-ksxSuHyLqkF5LEhSR1M1rKqNBUg@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCHv2] emerge: Don't die when the user has an invalid locale setting by Sebastian Luther
1 On Wed, Aug 6, 2014 at 5:55 PM, Sebastian Luther <SebastianLuther@×××.de> wrote:
2 > Am 06.08.2014 23:39, schrieb Mike Gilbert:
3 >> Resolves bug 519074.
4 >> ---
5 >> pym/_emerge/main.py | 5 ++++-
6 >> 1 file changed, 4 insertions(+), 1 deletion(-)
7 >>
8 >> diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py
9 >> index 1a920f7..52aa9c5 100644
10 >> --- a/pym/_emerge/main.py
11 >> +++ b/pym/_emerge/main.py
12 >> @@ -999,7 +999,10 @@ def emerge_main(args=None):
13 >> args = portage._decode_argv(args)
14 >>
15 >> # Use system locale.
16 >> - locale.setlocale(locale.LC_ALL, '')
17 >> + try:
18 >> + locale.setlocale(locale.LC_ALL, '')
19 >> + except locale.Error as e:
20 >> + writemsg_level("setlocale: %s\n" % e, level=logging.WARN)
21 >>
22 >> # Disable color until we're sure that it should be enabled (after
23 >> # EMERGE_DEFAULT_OPTS has been parsed).
24 >>
25 >
26 > Which locale does it use if this fails? Is it reasonable to continue?
27 >
28
29 As far as I can tell, it uses POSIX/C, just as if the call had never
30 taken place.

Replies