Re: [gentoo-portage-dev] [PATCHv2] emerge: Don't die when the user has an invalid locale setting

[Mike Gilbert]

On Wed, Aug 6, 2014 at 6:20 PM, Mike Gilbert <floppym@g.o> wrote:
> On Wed, Aug 6, 2014 at 5:55 PM, Sebastian Luther <SebastianLuther@×××.de> wrote:
>> Am 06.08.2014 23:39, schrieb Mike Gilbert:
>>> Resolves bug 519074.
>>> ---
>>>  pym/_emerge/main.py | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py
>>> index 1a920f7..52aa9c5 100644
>>> --- a/pym/_emerge/main.py
>>> +++ b/pym/_emerge/main.py
>>> @@ -999,7 +999,10 @@ def emerge_main(args=None):
>>>       args = portage._decode_argv(args)
>>>
>>>       # Use system locale.
>>> -     locale.setlocale(locale.LC_ALL, '')
>>> +     try:
>>> +             locale.setlocale(locale.LC_ALL, '')
>>> +     except locale.Error as e:
>>> +             writemsg_level("setlocale: %s\n" % e, level=logging.WARN)
>>>
>>>       # Disable color until we're sure that it should be enabled (after
>>>       # EMERGE_DEFAULT_OPTS has been parsed).
>>>
>>
>> Which locale does it use if this fails? Is it reasonable to continue?
>>
>
> As far as I can tell, it uses POSIX/C, just as if the call had never
> taken place.

From setlocale(3):

       If its value is not a valid locale specification, the locale is
unchanged, and setlocale()
       returns NULL.