Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: Zac Medico <zmedico@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)
Date: Tue, 15 Dec 2015 17:06:29
Message-Id: 20151215180613.62d67597.mgorny@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920) by Zac Medico
1 On Tue, 15 Dec 2015 08:50:10 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 12/15/2015 12:43 AM, Michał Górny wrote:
5 > > On Tue, 15 Dec 2015 00:10:03 -0800
6 > > Zac Medico <zmedico@g.o> wrote:
7 > >
8 > >> Include directory mtimes in the max mtime calculation, in order
9 > >> to account for removals and renames.
10 > >
11 > > Mildly irrelevant but I think this reached the point when we want to
12 > > make this optional, and off by default. In other words, we want
13 > > 'repoman manifest' run explicitly to work the old way.
14 > >
15 >
16 > I suppose we could support a "stable-mtime = true" attribute that would
17 > be set in layout.conf and/or repos.conf.
18
19 No. This is about tool behavior. Tool behavior should be set
20 in the tool, not in the object the tool is working on. It should be
21 a command-line option to repoman or egencache.
22
23 --
24 Best regards,
25 Michał Górny
26 <http://dev.gentoo.org/~mgorny/>