Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

[Brian Dolbec]

On Thu, 13 Aug 2015 11:36:58 -0700
Zac Medico <zmedico@g.o> wrote:

> On 08/13/2015 02:06 AM, Alexander Berntsen wrote:
> > Superficially it looks OK, except a few minor details.
> >
> > On 13/08/15 10:34, Zac Medico wrote:
> >> Repos are synced in parallel (includes their post-sync hooks).
> >> Output of concurrent processes is currently mixed (irrelevant with
> >> --quiet). Support for FEATURES=metadata-transfer is handled in the
> >> main process, which may be required for some backends (such as
> >> sqlite). Repos are synced only after their master(s) have synced
> >> (in case that matters for hooks).
> > The mix of tenses in here is making it difficult to read for me. The
> > present tense arguably should not be used since it is ambiguous.
> > Does it mean pre-patch or post-patch? Difficult to say. Please use
> > the imperative mood to dictate what a patch does.
>
> How's this future tense version?
>
> Repos will now be synced in parallel (including their post-sync
> hooks), but a given repo will only be synced after its master(s) have
> synced (in case that matters for hooks). Output of concurrent
> processes will be mixed (irrelevant with --quiet). Support for
> FEATURES=metadata-transfer will be handled in the main process, which
> may be required for some backends (such as sqlite).
>
>
>
> >> +class SyncScheduler(AsyncScheduler):
> > +	'''
> > +	Sync repos in parallel, but don't sync a given repo until
> > all
> > +	of it's masters have synced.
> > s/it's/its/
>
> Thanks, fixed.
>
> >
> > I tried applying it and testing it, and it seems to work for me.
> >
>
> Excellent!


That looks good to me :)

merge away :)

-- 
Brian Dolbec <dolsen>