| 1 |
On 08/13/2015 02:06 AM, Alexander Berntsen wrote: |
| 2 |
> Superficially it looks OK, except a few minor details. |
| 3 |
> |
| 4 |
> On 13/08/15 10:34, Zac Medico wrote: |
| 5 |
>> Repos are synced in parallel (includes their post-sync hooks). |
| 6 |
>> Output of concurrent processes is currently mixed (irrelevant with |
| 7 |
>> --quiet). Support for FEATURES=metadata-transfer is handled in the |
| 8 |
>> main process, which may be required for some backends (such as |
| 9 |
>> sqlite). Repos are synced only after their master(s) have synced |
| 10 |
>> (in case that matters for hooks). |
| 11 |
> The mix of tenses in here is making it difficult to read for me. The |
| 12 |
> present tense arguably should not be used since it is ambiguous. Does |
| 13 |
> it mean pre-patch or post-patch? Difficult to say. Please use the |
| 14 |
> imperative mood to dictate what a patch does. |
| 15 |
|
| 16 |
How's this future tense version? |
| 17 |
|
| 18 |
Repos will now be synced in parallel (including their post-sync hooks), |
| 19 |
but a given repo will only be synced after its master(s) have synced (in |
| 20 |
case that matters for hooks). Output of concurrent processes will be |
| 21 |
mixed (irrelevant with --quiet). Support for FEATURES=metadata-transfer |
| 22 |
will be handled in the main process, which may be required for some |
| 23 |
backends (such as sqlite). |
| 24 |
|
| 25 |
|
| 26 |
|
| 27 |
>> +class SyncScheduler(AsyncScheduler): |
| 28 |
> + ''' |
| 29 |
> + Sync repos in parallel, but don't sync a given repo until all |
| 30 |
> + of it's masters have synced. |
| 31 |
> s/it's/its/ |
| 32 |
|
| 33 |
Thanks, fixed. |
| 34 |
|
| 35 |
> |
| 36 |
> I tried applying it and testing it, and it seems to work for me. |
| 37 |
> |
| 38 |
|
| 39 |
Excellent! |
| 40 |
-- |
| 41 |
Thanks, |
| 42 |
Zac |
Archives