| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
Superficially it looks OK, except a few minor details. |
| 5 |
|
| 6 |
On 13/08/15 10:34, Zac Medico wrote: |
| 7 |
> Repos are synced in parallel (includes their post-sync hooks). |
| 8 |
> Output of concurrent processes is currently mixed (irrelevant with |
| 9 |
> --quiet). Support for FEATURES=metadata-transfer is handled in the |
| 10 |
> main process, which may be required for some backends (such as |
| 11 |
> sqlite). Repos are synced only after their master(s) have synced |
| 12 |
> (in case that matters for hooks). |
| 13 |
The mix of tenses in here is making it difficult to read for me. The |
| 14 |
present tense arguably should not be used since it is ambiguous. Does |
| 15 |
it mean pre-patch or post-patch? Difficult to say. Please use the |
| 16 |
imperative mood to dictate what a patch does. |
| 17 |
|
| 18 |
> +class SyncScheduler(AsyncScheduler): |
| 19 |
+ ''' |
| 20 |
+ Sync repos in parallel, but don't sync a given repo until all |
| 21 |
+ of it's masters have synced. |
| 22 |
s/it's/its/ |
| 23 |
|
| 24 |
|
| 25 |
I tried applying it and testing it, and it seems to work for me. |
| 26 |
- -- |
| 27 |
Alexander |
| 28 |
bernalex@g.o |
| 29 |
https://secure.plaimi.net/~alexander |
| 30 |
-----BEGIN PGP SIGNATURE----- |
| 31 |
Version: GnuPG v2 |
| 32 |
|
| 33 |
iQIcBAEBCgAGBQJVzF4bAAoJENQqWdRUGk8BQj8P/jLv1aF+X+WjZ/Yb0W9EgRrQ |
| 34 |
IsztoXr1a+p5HdES/MXvjMcIh+dULiLvxdpxCBAHDj+Lk445H7uQ3R0BGbJgYGZG |
| 35 |
fkVqV/OUff99O11lbiSaLVOlZhASsDKlRBkXnhYzbq+4wyxYdo2b+TKaqrziTp0j |
| 36 |
cH3XSt3GQojbWxXOWNz6AUE0ZuqNepeBYlFeRvTip7J/kYvNSiBmYqnFBFtOxXFz |
| 37 |
rlD7jPRrCUqNx8dIGEUZkV/niVL2uwVjoOAmC080g31JUcnWUP4L3L7GQcrbwsar |
| 38 |
FwNG8/nLlJjKH5B/eZkNBEPk4mscxYauXkqrn75f8MfubSmdJjjqY84VxcpMgHds |
| 39 |
ftOY2kKTcHpi+os67wGPVIfFfopqu0C5N9OxdXraeyBl5i50Idvshjaqrrm7+gsD |
| 40 |
+VGrU0jmcdY+JfU3KsWJIY3X46QRByR6oSqHG9CdIcL5ZoKYfEKpcsSCkjKCdcV3 |
| 41 |
4MVI2HCUstmvKlqRcidxs9P3LqoHNiDUUBhyBSErcy3V29f9001Hap+/UOSlS8VM |
| 42 |
jTNM8cLtKQ7WM5o2rwXSva3TU0i3TN6oigso14+phbXjm6GasyQ08GW6HjTgZC5D |
| 43 |
P4g0xsSkqU+5l+N5JxknRNEw8pvk4JopqYeWCF5V4bKhyY6jqJRqStL1S4GCeoVD |
| 44 |
tBjsoa3nHxoi//HVYAjW |
| 45 |
=GC5L |
| 46 |
-----END PGP SIGNATURE----- |
Archives