Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Add a check for relative dosym candidates
Date: Sat, 15 Apr 2017 17:49:14
Message-Id: 20170415104907.723f957b.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] repoman: Add a check for relative dosym candidates by Zac Medico
1 On Sat, 15 Apr 2017 10:11:33 -0700
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On Sat, Apr 15, 2017 at 4:04 AM, Michał Górny <mgorny@g.o>
5 > wrote:
6 > > diff --git a/repoman/pym/repoman/modules/scan/ebuild/checks.py
7 > > b/repoman/pym/repoman/modules/scan/ebuild/checks.py index
8 > > 57c8b10a5..e6e5d78ba 100644 ---
9 > > a/repoman/pym/repoman/modules/scan/ebuild/checks.py +++
10 > > b/repoman/pym/repoman/modules/scan/ebuild/checks.py @@ -921,7
11 > > +921,7 @@ class EbuildNonRelativeDosym(LineCheck): def check(self,
12 > > num, line): match = self.regex.match(line)
13 > > if match:
14 > > - return "dosym '%s' could use relative path"
15 > > % (match.group(1), ) + " on line: %d"
16 > > + return "dosym '%s'... could use relative
17 > > path" % (match.group(1), ) + " on line: %d"
18 > >
19 > >
20 > > _base_check_classes = (InheritEclass, LineCheck, PhaseCheck)
21 >
22 > It looks like you forgot to post a first patch in this series, because
23 > I don't see a EbuildNonRelativeDosym class anywhere:
24 >
25 > https://github.com/gentoo/portage/search?utf8=%E2%9C%93&q=EbuildNonRelativeDosym&type=
26 >
27
28 nice catch Zac. I obviously didn't look closely enough :/
29
30 --
31 Brian Dolbec <dolsen>