Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Add a check for relative dosym candidates
Date: Sat, 15 Apr 2017 17:11:35
Message-Id: CAMiTYSq3Us-5brPj5A1DV6deRo+b-WE+VuON8JWQdsGD4CcE=A@mail.gmail.com
In Reply to: [gentoo-portage-dev] [PATCH] repoman: Add a check for relative dosym candidates by "Michał Górny"
1 On Sat, Apr 15, 2017 at 4:04 AM, Michał Górny <mgorny@g.o> wrote:
2 > diff --git a/repoman/pym/repoman/modules/scan/ebuild/checks.py b/repoman/pym/repoman/modules/scan/ebuild/checks.py
3 > index 57c8b10a5..e6e5d78ba 100644
4 > --- a/repoman/pym/repoman/modules/scan/ebuild/checks.py
5 > +++ b/repoman/pym/repoman/modules/scan/ebuild/checks.py
6 > @@ -921,7 +921,7 @@ class EbuildNonRelativeDosym(LineCheck):
7 > def check(self, num, line):
8 > match = self.regex.match(line)
9 > if match:
10 > - return "dosym '%s' could use relative path" % (match.group(1), ) + " on line: %d"
11 > + return "dosym '%s'... could use relative path" % (match.group(1), ) + " on line: %d"
12 >
13 >
14 > _base_check_classes = (InheritEclass, LineCheck, PhaseCheck)
15
16 It looks like you forgot to post a first patch in this series, because
17 I don't see a EbuildNonRelativeDosym class anywhere:
18
19 https://github.com/gentoo/portage/search?utf8=%E2%9C%93&q=EbuildNonRelativeDosym&type=
20
21 --
22 Thanks,
23 Zac

Replies