Re: [gentoo-portage-dev] [PATCH] repoman: Add a check for relative dosym candidates

[Michał Górny]

On sob, 2017-04-15 at 10:11 -0700, Zac Medico wrote:
> On Sat, Apr 15, 2017 at 4:04 AM, Michał Górny <mgorny@g.o> wrote:
> > diff --git a/repoman/pym/repoman/modules/scan/ebuild/checks.py b/repoman/pym/repoman/modules/scan/ebuild/checks.py
> > index 57c8b10a5..e6e5d78ba 100644
> > --- a/repoman/pym/repoman/modules/scan/ebuild/checks.py
> > +++ b/repoman/pym/repoman/modules/scan/ebuild/checks.py
> > @@ -921,7 +921,7 @@ class EbuildNonRelativeDosym(LineCheck):
> >         def check(self, num, line):
> >                 match = self.regex.match(line)
> >                 if match:
> > -                       return "dosym '%s' could use relative path" % (match.group(1), ) + " on line: %d"
> > +                       return "dosym '%s'... could use relative path" % (match.group(1), ) + " on line: %d"
> >
> >
> >  _base_check_classes = (InheritEclass, LineCheck, PhaseCheck)
>
> It looks like you forgot to post a first patch in this series, because
> I don't see a EbuildNonRelativeDosym class anywhere:
>
>     https://github.com/gentoo/portage/search?utf8=%E2%9C%93&q=EbuildNonRelativeDosym&type=
>

Yeah, I'm sorry, I forgot that I had an earlier commit and didn't squash
it properly.

-- 
Best regards,
Michał Górny