Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
Date: Thu, 05 Feb 2015 14:51:41
Message-Id: 54D38376.60901@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v2] sync: support sync-depth for DVCS-es (git --depth) by Brian Dolbec
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 18/01/15 17:33, Brian Dolbec wrote:
5 > Yeah, just move this to sorted order like Arfrever said. Otherwise
6 > it looks good, ready to merge.
7 Friends,
8
9 I want to strongly discourage ACKs like "this looks good, but change
10 this one thing before you push". Anyone can make a typo or other error
11 in between such revisions. I would strongly prefer if we required a
12 review of the patch that is to be pushed.
13 - --
14 Alexander
15 bernalex@g.o
16 https://secure.plaimi.net/~alexander
17 -----BEGIN PGP SIGNATURE-----
18 Version: GnuPG v2
19 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
20
21 iF4EAREIAAYFAlTTg3YACgkQRtClrXBQc7VWowD9HU+6r60LVNVXRC6B2W5oetIg
22 +olHBuauHEA7FCVYANUA/04B9hq8Njy+osgtiWeI4ZFG0WukkKDzEsOS5+d6wDg6
23 =8gwQ
24 -----END PGP SIGNATURE-----

Replies