Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
Date: Thu, 05 Feb 2015 16:34:25
Message-Id: 20150205083419.72867c68.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." by Alexander Berntsen
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On Thu, 05 Feb 2015 15:51:34 +0100
5 Alexander Berntsen <bernalex@g.o> wrote:
6
7
8 > On 18/01/15 17:33, Brian Dolbec wrote:
9 > > Yeah, just move this to sorted order like Arfrever said. Otherwise
10 > > it looks good, ready to merge.
11 > Friends,
12 >
13 > I want to strongly discourage ACKs like "this looks good, but change
14 > this one thing before you push". Anyone can make a typo or other error
15 > in between such revisions. I would strongly prefer if we required a
16 > review of the patch that is to be pushed.
17 > - --
18 > Alexander
19 > bernalex@g.o
20 > https://secure.plaimi.net/~alexander
21 >
22
23 Fair enough :)
24
25 - --
26 Brian Dolbec <dolsen>
27
28 -----BEGIN PGP SIGNATURE-----
29 Version: GnuPG v2.0
30
31 iQJ8BAEBCgBmBQJU05uLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
32 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
33 QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7Y6xcQALc71qmlrF6p53vQIqc4Zk4J
34 +KjUmpa3dHdOPfkYT9jEjpspsF8Y21n3BWuPfHiWsJ1Vgzlku6M19WSwTMAjHECV
35 3T460/CIJT2nJKPCLQLlzW9qaxmPntNqPMx9z7k2YCGBMtEX3VA2soP+HBqJ7il4
36 iFBUSiCZs68L4+0NFRgmTZox/CF6NS8t50sBZWe3vEtpIqGjidA96HlSGkmD60nM
37 RBRGydcU0OKNccc0s7bcE0PQFYEfcYIvoY39grTSZxZy78/tUStRqeV4VChxp042
38 oF/2nxGAjNhfFh2Erlv49FHJuUMQ2nRR3IkpIfvMR8WdKvKnAQ6m8WWAySnnVkOr
39 KqrAbnHWgFOMqDH8jBC9ny/6JRR675nB1mqKrCZQQt23p6ZGPEENKoxhepk5Mj0N
40 cXd/wTzQpswJUfejPoyuI3b/+IoXfEEpBuMvk7uAf4bPu00/4aL3NV5BqCYoVY4D
41 Zw0EHI/qVCEdlNAsj3TIQVazWW4W9HwzGJRYHoNoJdmBWVdyY/YFrQwshiAaPGpT
42 XKKl3Kd2UnsLm9INB3vlucxSWxwWFV6OlOg4klYHanDAxRqOXb+pUei+W3B/SBLe
43 iN7in8r1F9uIYg+fDbC2w4Qh2/u0FaNvnuoRwft/MD665lXIZkp7rBGaGo2NwCY/
44 WGW4YUtin0I8hS0HNnyQ
45 =zYYm
46 -----END PGP SIGNATURE-----