Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place
Date: Thu, 11 Jun 2015 05:43:45
Message-Id: 5579200A.3060102@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place by Mike Frysinger
1 On 06/10/2015 10:39 PM, Mike Frysinger wrote:
2 > On 10 Jun 2015 11:54, Zac Medico wrote:
3 >> On 05/30/2015 01:59 PM, Mike Frysinger wrote:
4 >> LGTM, except this one line is indented with spaces instead of tabs in
5 >> vartree.py:
6 >>
7 >>> def tar_contents(contents, root, tar, protect=None, onProgress=None,
8 >>> - xattr=False):
9 >>> + xattrs=False):
10 >
11 > i don't know if we have a standard here. sometimes it's a single tab, sometimes
12 > it's spaces to line up. i prefer the latter as that's generally what PEP8 does.
13 > -mike
14 >
15
16 Ah, ok. The test pass, so guess it's fine that way.
17 --
18 Thanks,
19 Zac

Replies