Archives
Archives
| From: | Mike Frysinger <vapier@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place | ||
| Date: | Thu, 11 Jun 2015 05:39:39 | ||
| Message-Id: | 20150611053930.GK13517@vapier | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place by Zac Medico |
||
| 1 | On 10 Jun 2015 11:54, Zac Medico wrote: |
| 2 | > On 05/30/2015 01:59 PM, Mike Frysinger wrote: |
| 3 | > LGTM, except this one line is indented with spaces instead of tabs in |
| 4 | > vartree.py: |
| 5 | > |
| 6 | > > def tar_contents(contents, root, tar, protect=None, onProgress=None, |
| 7 | > > - xattr=False): |
| 8 | > > + xattrs=False): |
| 9 | |
| 10 | i don't know if we have a standard here. sometimes it's a single tab, sometimes |
| 11 | it's spaces to line up. i prefer the latter as that's generally what PEP8 does. |
| 12 | -mike |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place | Zac Medico <zmedico@g.o> |