Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place

[Zac Medico]

On 05/30/2015 01:59 PM, Mike Frysinger wrote:
> Rather than each module implementing its own shim around the various
> methods for accessing extended attributes, start a dedicated module
> that exports a consistent API.
> ---
> v4
> 	- merge in recent quickpkg changes
> 	- add a XATTRS_WORKS symbol for easy testing
> 	- use - with -m when matching all
>
>  bin/quickpkg                         |  12 +-
>  bin/xattr-helper.py                  |  11 +-
>  pym/portage/dbapi/vartree.py         |  10 +-
>  pym/portage/tests/util/test_xattr.py | 178 +++++++++++++++++++++++++++
>  pym/portage/util/_xattr.py           | 228 +++++++++++++++++++++++++++++++++++
>  pym/portage/util/movefile.py         | 100 ++++-----------
>  pym/portage/util/xattr.py            |  20 ---
>  7 files changed, 441 insertions(+), 118 deletions(-)
>  create mode 100644 pym/portage/tests/util/test_xattr.py
>  create mode 100644 pym/portage/util/_xattr.py
>  delete mode 100644 pym/portage/util/xattr.py
>

LGTM, except this one line is indented with spaces instead of tabs in
vartree.py:

>  def tar_contents(contents, root, tar, protect=None, onProgress=None,
> -	xattr=False):
> +                 xattrs=False):

-- 
Thanks,
Zac