| 1 |
On 01/25/2018 01:11 AM, Michał Górny wrote: |
| 2 |
> W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael |
| 3 |
> Haubenwallner napisał: |
| 4 |
>> Hi, |
| 5 |
>> |
| 6 |
>> ${Subject} ringing a bell here: |
| 7 |
>> |
| 8 |
>> dev-db/oracle-instantclient is fetch restricted. As a binary package with |
| 9 |
>> multiple USE options there's a bunch of files to download - even for |
| 10 |
>> multiple archs when multilib is active. |
| 11 |
>> |
| 12 |
>> So in pkg_nofetch() I'm telling the user whether a file to download is |
| 13 |
>> "already here" or "still absent", by testing if $A exists in $DISTDIR. |
| 14 |
>> |
| 15 |
>> With ${Subject}, I'm wondering if DISTDIR is created for pkg_nofetch too. |
| 16 |
>> |
| 17 |
> |
| 18 |
> You're doing the wrong thing then. DISTDIR is not allowed |
| 19 |
> in pkg_nofetch(). |
| 20 |
|
| 21 |
It seems to be a common assumption that it's allowed, this command |
| 22 |
currently shows 163 results in the gentoo repo: |
| 23 |
|
| 24 |
git grep -l pkg_nofetch | xargs grep 'e\(log\|info\).*DISTDIR' | wc -l |
| 25 |
|
| 26 |
We should double check with the PMS maintainers to see if they think |
| 27 |
it's worthy of an exception. Otherwise, we need to announce the issue on |
| 28 |
the gentoo-dev mailing list. |
| 29 |
|
| 30 |
Furthermore, you're touching files whose hashes have |
| 31 |
> not been verified which is twice wrong. |
| 32 |
|
| 33 |
Checking if files exist is not really a security risk, but yes, we |
| 34 |
should conform to the spec. |
| 35 |
-- |
| 36 |
Thanks, |
| 37 |
Zac |
Archives