Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Re: [PATCH v2 3/3] _emerge.Ebuild*: delay creating DISTDIR shadow until src_unpack
Date: Thu, 25 Jan 2018 09:11:08
Message-Id: 1516871461.1833.2.camel@gentoo.org
In Reply to: [gentoo-portage-dev] Re: [PATCH v2 3/3] _emerge.Ebuild*: delay creating DISTDIR shadow until src_unpack by Michael Haubenwallner
1 W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael
2 Haubenwallner napisał:
3 > Hi,
4 >
5 > ${Subject} ringing a bell here:
6 >
7 > dev-db/oracle-instantclient is fetch restricted. As a binary package with
8 > multiple USE options there's a bunch of files to download - even for
9 > multiple archs when multilib is active.
10 >
11 > So in pkg_nofetch() I'm telling the user whether a file to download is
12 > "already here" or "still absent", by testing if $A exists in $DISTDIR.
13 >
14 > With ${Subject}, I'm wondering if DISTDIR is created for pkg_nofetch too.
15 >
16
17 You're doing the wrong thing then. DISTDIR is not allowed
18 in pkg_nofetch(). Furthermore, you're touching files whose hashes have
19 not been verified which is twice wrong.
20
21 --
22 Best regards,
23 Michał Górny

Replies