Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default
Date: Mon, 31 Jul 2017 08:17:59
Message-Id: CAMiTYSqj5MN+ZouPuN61oj+CNtXVvMJx=skZvpKHFB=3uGuVmA@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default by "Michał Górny"
1 On Wed, Jul 26, 2017 at 1:44 PM, Michał Górny <mgorny@g.o> wrote:
2 > On śro, 2017-07-26 at 11:29 -0700, Zac Medico wrote:
3 >> You might think that, but I just checked our profiles and the only one
4 >> that currently has it enabled is profiles/arch/sparc/make.defaults. In
5 >> profiles/targets/developer/make.defaults there's a reference to this
6 >> bug that's been open for 5 years now:
7 >>
8 >> https://bugs.gentoo.org/show_bug.cgi?id=424423
9 >
10 > To be honest, I started rewriting multilib-strict to be sane but lost
11 > motivation pretty early. Feel free to take it up, it shouldn't be hard.
12 > Just horribly boring.
13 >
14 > Basically, it should iterate over all ABIs, get libdirs for them
15 > and look for libraries *directly* in those libdirs. Anything below first
16 > level can be ignored as unclear with a good hit rate anyway.
17
18 Assuming that MULTILIB_STRICT_DIRS contains a reasonable list of
19 libdirs for the profile, can't we get that behavior by adding
20 -maxdepth 1 to the find call inside
21 bin/install-qa-check.d/80multilib-strict? If so, then why haven't we
22 done this already?
23 --
24 Thanks,
25 Zac

Replies