Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default
Date: Wed, 26 Jul 2017 20:44:57
Message-Id: 1501101877.23673.1.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default by Zac Medico
1 On śro, 2017-07-26 at 11:29 -0700, Zac Medico wrote:
2 > On Wed, Jul 26, 2017 at 10:11 AM, Michał Górny <mgorny@g.o> wrote:
3 > > On śro, 2017-07-26 at 09:58 -0700, Zac Medico wrote:
4 > > > On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny <mgorny@g.o> wrote:
5 > > > > Enable the multilib-strict feature necessary for Portage to detect
6 > > > > ebuilds not respecting libdir for libraries. Since those issues were
7 > > > > reliably fixed over the years and we're nearing the removal of 'lib'
8 > > > > symlink, I think we can safely enable it by default for our users
9 > > > > without risking many additional issues for them.
10 > > > >
11 > > > > At the same time, many proxied maintainers keep submitting ebuilds that
12 > > > > do not respect libdir, and that require us to explicitly point that out
13 > > > > to them. Having Portage detect that by default would be really helpful.
14 > > > > ---
15 > > > > cnf/make.globals | 3 ++-
16 > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
17 > > >
18 > > > That seems reasonable, especially given that the profile controls the
19 > > > MULTILIB_STRICT_* variables that enable this. Maybe this is worthy of
20 > > > sending a warning to the -dev mailing list?
21 > >
22 > > I could do that. However, I suspect that everyone who's developing
23 > > Gentoo in any way already uses it ;-).
24 >
25 > You might think that, but I just checked our profiles and the only one
26 > that currently has it enabled is profiles/arch/sparc/make.defaults. In
27 > profiles/targets/developer/make.defaults there's a reference to this
28 > bug that's been open for 5 years now:
29 >
30 > https://bugs.gentoo.org/show_bug.cgi?id=424423
31
32 To be honest, I started rewriting multilib-strict to be sane but lost
33 motivation pretty early. Feel free to take it up, it shouldn't be hard.
34 Just horribly boring.
35
36 Basically, it should iterate over all ABIs, get libdirs for them
37 and look for libraries *directly* in those libdirs. Anything below first
38 level can be ignored as unclear with a good hit rate anyway.
39
40 --
41 Best regards,
42 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies