Re: [gentoo-portage-dev] [PATCH] Bundle a minimalistic derivation of Python's formatter module (bug 547732)

[Zac Medico]

On 04/28/2015 05:07 PM, Brian Dolbec wrote:
> On Sat, 25 Apr 2015 13:37:10 -0700
> Zac Medico <zmedico@g.o> wrote:
>
>> Python's formatter module is scheduled for removal in Python 3.6, so
>> replace it with a minimalistic derivation.
>>
>> X-Gentoo-Bug: 547732
>> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=547732
>> ---
>>  bin/repoman                     |  2 +-
>>  pym/_emerge/JobStatusDisplay.py |  4 +--
>>  pym/portage/output.py           |  4 +--
>>  pym/portage/util/formatter.py   | 69
>> +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 74
>> insertions(+), 5 deletions(-) create mode 100644
>> pym/portage/util/formatter.py
>>
>>
>
>
> Is this really the best way to deal with the deprecation for py3.6+  ???

I think it's reasonable because it allows us to avoid migrating the
formatting code to some other API.

Both repoman and JobStatusDisplay use this API to render both formatted
and unformatted output simultaneously. They display styled output with
colors on the console, and also render an unformatted version (repoman's
commit message and JobStatusDisplay's xterm titiles).
-- 
Thanks,
Zac