| 1 |
On 04/28/15 18:48, Zac Medico wrote: |
| 2 |
> On 04/28/2015 05:07 PM, Brian Dolbec wrote: |
| 3 |
>> On Sat, 25 Apr 2015 13:37:10 -0700 |
| 4 |
>> Zac Medico <zmedico@g.o> wrote: |
| 5 |
>> |
| 6 |
>>> Python's formatter module is scheduled for removal in Python 3.6, so |
| 7 |
>>> replace it with a minimalistic derivation. |
| 8 |
>>> |
| 9 |
>>> X-Gentoo-Bug: 547732 |
| 10 |
>>> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=547732 |
| 11 |
>>> --- |
| 12 |
>>> bin/repoman | 2 +- |
| 13 |
>>> pym/_emerge/JobStatusDisplay.py | 4 +-- |
| 14 |
>>> pym/portage/output.py | 4 +-- |
| 15 |
>>> pym/portage/util/formatter.py | 69 |
| 16 |
>>> +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 74 |
| 17 |
>>> insertions(+), 5 deletions(-) create mode 100644 |
| 18 |
>>> pym/portage/util/formatter.py |
| 19 |
>>> |
| 20 |
>>> |
| 21 |
>> |
| 22 |
>> |
| 23 |
>> Is this really the best way to deal with the deprecation for py3.6+ ??? |
| 24 |
> |
| 25 |
> I think it's reasonable because it allows us to avoid migrating the |
| 26 |
> formatting code to some other API. |
| 27 |
> |
| 28 |
> Both repoman and JobStatusDisplay use this API to render both formatted |
| 29 |
> and unformatted output simultaneously. They display styled output with |
| 30 |
> colors on the console, and also render an unformatted version (repoman's |
| 31 |
> commit message and JobStatusDisplay's xterm titiles). |
| 32 |
> |
| 33 |
|
| 34 |
Looks good? |
| 35 |
-- |
| 36 |
Thanks, |
| 37 |
Zac |
Archives