| 1 |
On Wed, 06 May 2015 10:39:26 -0700 |
| 2 |
Zac Medico <zmedico@g.o> wrote: |
| 3 |
|
| 4 |
> On 04/28/15 18:48, Zac Medico wrote: |
| 5 |
> > On 04/28/2015 05:07 PM, Brian Dolbec wrote: |
| 6 |
> >> On Sat, 25 Apr 2015 13:37:10 -0700 |
| 7 |
> >> Zac Medico <zmedico@g.o> wrote: |
| 8 |
> >> |
| 9 |
> >>> Python's formatter module is scheduled for removal in Python 3.6, |
| 10 |
> >>> so replace it with a minimalistic derivation. |
| 11 |
> >>> |
| 12 |
> >>> X-Gentoo-Bug: 547732 |
| 13 |
> >>> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=547732 |
| 14 |
> >>> --- |
| 15 |
> >>> bin/repoman | 2 +- |
| 16 |
> >>> pym/_emerge/JobStatusDisplay.py | 4 +-- |
| 17 |
> >>> pym/portage/output.py | 4 +-- |
| 18 |
> >>> pym/portage/util/formatter.py | 69 |
| 19 |
> >>> +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 74 |
| 20 |
> >>> insertions(+), 5 deletions(-) create mode 100644 |
| 21 |
> >>> pym/portage/util/formatter.py |
| 22 |
> >>> |
| 23 |
> >>> |
| 24 |
> >> |
| 25 |
> >> |
| 26 |
> >> Is this really the best way to deal with the deprecation for |
| 27 |
> >> py3.6+ ??? |
| 28 |
> > |
| 29 |
> > I think it's reasonable because it allows us to avoid migrating the |
| 30 |
> > formatting code to some other API. |
| 31 |
> > |
| 32 |
> > Both repoman and JobStatusDisplay use this API to render both |
| 33 |
> > formatted and unformatted output simultaneously. They display |
| 34 |
> > styled output with colors on the console, and also render an |
| 35 |
> > unformatted version (repoman's commit message and |
| 36 |
> > JobStatusDisplay's xterm titiles). |
| 37 |
> > |
| 38 |
> |
| 39 |
> Looks good? |
| 40 |
|
| 41 |
Yeah, as much as I'd prefer to replace the use of the code. There |
| 42 |
seems to be no suggestions on replacements or how best to. |
| 43 |
|
| 44 |
So, yes, merge it. |
| 45 |
|
| 46 |
-- |
| 47 |
Brian Dolbec <dolsen> |
Archives