1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
Marius Mauch wrote: |
5 |
> Marius Mauch schrieb: |
6 |
>> The first should be delayed until there is some consensus how the gpg |
7 |
>> stuff should work in the future, the others I don't see the use for. |
8 |
>> Also I only checked portage.py for changes, so emerge/repoman/... might |
9 |
>> still have to be fixed. |
10 |
>> Last but not least: I did some basic testing with this and the |
11 |
>> important stuff seems to work, but I'm quite sure the code still has a |
12 |
>> lot of bugs/issues, and this being a core functionality it needs a |
13 |
>> *lot* of testing, so I'd really appreciate if you could all give it a |
14 |
>> spin (but do not commit anything to the tree without manually checking |
15 |
>> it first). |
16 |
> |
17 |
> Does the lack of feedback (only got a reaction from Brian so far) mean |
18 |
> that noone tried it or that it doesn't have any issues? |
19 |
|
20 |
The patch applies and seems to work well. At a quick glance the code looks pretty clean and it's nice to migrate more code out of portage.py to a separate module. I've attached a refreshed version of the patch that applies cleanly against current svn (I've made no changes). |
21 |
|
22 |
Zac |
23 |
-----BEGIN PGP SIGNATURE----- |
24 |
Version: GnuPG v1.4.2.2 (GNU/Linux) |
25 |
|
26 |
iD8DBQFEGP1S/ejvha5XGaMRAl/7AJ9cZbjhWtjCz+ac2/tjQNUoivj0twCg7xAG |
27 |
cYvDbMiqU5HtpNrVk7fs6RM= |
28 |
=Eqlo |
29 |
-----END PGP SIGNATURE----- |