Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: use asyncio interfaces for spinner during owner lookup (bug 591760)
Date: Mon, 27 Mar 2017 02:28:02
Message-Id: CAMiTYSoCySz5uimyj=pOBCMarELCLoLz2o9VonNRv0kQke-52A@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCH] emerge: use asyncio interfaces for spinner during owner lookup (bug 591760) by Zac Medico
1 On Sun, Mar 26, 2017 at 7:25 PM, Zac Medico <zmedico@g.o> wrote:
2 > On Sun, Mar 26, 2017 at 6:58 PM, Brian Dolbec <dolsen@g.o> wrote:
3 >> On Sun, 26 Mar 2017 18:01:01 -0700
4 >> Zac Medico <zmedico@g.o> wrote:
5 >>
6 >>> X-Gentoo-bug: 591760
7 >>> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=591760
8 >>> ---
9 >>> pym/_emerge/depgraph.py | 13 ++++++++-----
10 >>> pym/portage/dbapi/vartree.py | 22 +++++++++-------------
11 >>> 2 files changed, 17 insertions(+), 18 deletions(-)
12 >>>
13 >> looks fine.
14 >
15 > Thanks, pushed:
16 >
17 > https://gitweb.gentoo.org/proj/portage.git/commit/?id=dfa317d0b8572a6c463ad5e778a8ca4633086f1b
18 >
19 >> Question, will this help make the spinner more consistent with spin?
20 >
21 > Well, that problem was already solved for the case where emerge is
22 > looking up owners of files, which is the case that this code affects.
23 >
24 > I'm sure there are plenty of other places where the spinner does not
25 > update consistently. This occurs when the main (and only) thread goes
26 > for a long time without calling depgraph._spinner_update(). For
27 > example, some of the code called via the
28 > depgraph._process_slot_conflicts method might we consuming a lot of
29 > time without calling the _spinner_update method.
30
31 When the spinner appears to be stuck, you can send a SIGUSR1 signal to
32 the emerge process, and then use 'bt' to get a backtrace so that we
33 can see what it's doing.
34 --
35 Thanks,
36 Zac