| 1 |
On Sun, Mar 26, 2017 at 6:58 PM, Brian Dolbec <dolsen@g.o> wrote: |
| 2 |
> On Sun, 26 Mar 2017 18:01:01 -0700 |
| 3 |
> Zac Medico <zmedico@g.o> wrote: |
| 4 |
> |
| 5 |
>> X-Gentoo-bug: 591760 |
| 6 |
>> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=591760 |
| 7 |
>> --- |
| 8 |
>> pym/_emerge/depgraph.py | 13 ++++++++----- |
| 9 |
>> pym/portage/dbapi/vartree.py | 22 +++++++++------------- |
| 10 |
>> 2 files changed, 17 insertions(+), 18 deletions(-) |
| 11 |
>> |
| 12 |
> looks fine. |
| 13 |
|
| 14 |
Thanks, pushed: |
| 15 |
|
| 16 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=dfa317d0b8572a6c463ad5e778a8ca4633086f1b |
| 17 |
|
| 18 |
> Question, will this help make the spinner more consistent with spin? |
| 19 |
|
| 20 |
Well, that problem was already solved for the case where emerge is |
| 21 |
looking up owners of files, which is the case that this code affects. |
| 22 |
|
| 23 |
I'm sure there are plenty of other places where the spinner does not |
| 24 |
update consistently. This occurs when the main (and only) thread goes |
| 25 |
for a long time without calling depgraph._spinner_update(). For |
| 26 |
example, some of the code called via the |
| 27 |
depgraph._process_slot_conflicts method might we consuming a lot of |
| 28 |
time without calling the _spinner_update method. |
| 29 |
-- |
| 30 |
Thanks, |
| 31 |
Zac |
Archives