Archives
Archives
| From: | "Michał Górny" <mgorny@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o, Zac Medico <zmedico@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages | ||
| Date: | Sun, 30 Jul 2017 05:50:18 | ||
| Message-Id: | 1501393812.1034.2.camel@gentoo.org | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages by "Manuel Rüger" |
||
| 1 | On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote: |
| 2 | > Pushed as: |
| 3 | > https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471 |
| 4 | > |
| 5 | > Thanks for the patient reviews, Zac! |
| 6 | > |
| 7 | |
| 8 | I'm sorry for noticing this only now when I'm enabling it but we have |
| 9 | already: |
| 10 | |
| 11 | PORTAGE_COMPRESS |
| 12 | PORTAGE_COMPRESS_FLAGS |
| 13 | ^^^^^^ |
| 14 | |
| 15 | and you've added: |
| 16 | |
| 17 | BINPKG_COMPRESSION |
| 18 | ^^^ |
| 19 | BINPKG_COMPRESSION_ARGS |
| 20 | ^^^^^^^^ |
| 21 | |
| 22 | Wouldn't it be better to at least try having consistent variable naming? |
| 23 | |
| 24 | -- |
| 25 | Best regards, |
| 26 | Michał Górny |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages | Zac Medico <zmedico@g.o> |