| 1 |
On Sat, Jul 29, 2017 at 10:50 PM, Michał Górny <mgorny@g.o> wrote: |
| 2 |
> On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote: |
| 3 |
>> Pushed as: |
| 4 |
>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471 |
| 5 |
>> |
| 6 |
>> Thanks for the patient reviews, Zac! |
| 7 |
>> |
| 8 |
> |
| 9 |
> I'm sorry for noticing this only now when I'm enabling it but we have |
| 10 |
> already: |
| 11 |
> |
| 12 |
> PORTAGE_COMPRESS |
| 13 |
> PORTAGE_COMPRESS_FLAGS |
| 14 |
> ^^^^^^ |
| 15 |
> |
| 16 |
> and you've added: |
| 17 |
> |
| 18 |
> BINPKG_COMPRESSION |
| 19 |
> ^^^ |
| 20 |
> BINPKG_COMPRESSION_ARGS |
| 21 |
> ^^^^^^^^ |
| 22 |
> |
| 23 |
> Wouldn't it be better to at least try having consistent variable naming? |
| 24 |
|
| 25 |
Yeah, let's change it to BINPKG_COMPRESS and BINPKG_COMPRESS_FLAGS. |
| 26 |
-- |
| 27 |
Thanks, |
| 28 |
Zac |
Archives