Gentoo Archives: gentoo-portage-dev

From:	Zac Medico <zmedico@g.o>
To:	"Michał Górny" <mgorny@g.o>
Cc:	gentoo-portage-dev@l.g.o
Subject:	Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages
Date:	Sun, 30 Jul 2017 20:59:51
Message-Id:	`CAMiTYSqazWsWmPzE8b2M=WCnJ=W-9Ku5mQO7REaKpOMrjB6iBw@mail.gmail.com`
In Reply to:	Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages by Zac Medico

1	On Sun, Jul 30, 2017 at 1:27 PM, Zac Medico <zmedico@g.o> wrote:
2	> On Sat, Jul 29, 2017 at 10:50 PM, Michał Górny <mgorny@g.o> wrote:
3	>> On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote:
4	>>> Pushed as:
5	>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471
6	>>>
7	>>> Thanks for the patient reviews, Zac!
8	>>>
9	>>
10	>> I'm sorry for noticing this only now when I'm enabling it but we have
11	>> already:
12	>>
13	>> PORTAGE_COMPRESS
14	>> PORTAGE_COMPRESS_FLAGS
15	>> ^^^^^^
16	>>
17	>> and you've added:
18	>>
19	>> BINPKG_COMPRESSION
20	>> ^^^
21	>> BINPKG_COMPRESSION_ARGS
22	>> ^^^^^^^^
23	>>
24	>> Wouldn't it be better to at least try having consistent variable naming?
25	>
26	> Yeah, let's change it to BINPKG_COMPRESS and BINPKG_COMPRESS_FLAGS.
27
28	Pushed:
29
30	https://gitweb.gentoo.org/proj/portage.git/commit/?id=2c7d38b9512609f6828cbba1066f2b3b2d9144bf
31	--
32	Thanks,
33	Zac