| 1 |
On Monday 16 January 2006 19:52, Zac Medico wrote: |
| 2 |
> Mike Frysinger wrote: |
| 3 |
> > - for x in specials["LDPATH"]+['/usr/lib','/lib']: |
| 4 |
> > + skip_makelinks=1 |
| 5 |
> > + for x in |
| 6 |
> > portage_util.unique_array(specials["LDPATH"]+['/usr/lib','/usr/lib64','/u |
| 7 |
> >sr/lib32','/lib','/lib64','/lib32']): + if makelinks and skip_makelinks |
| 8 |
> > and os.access(srcroot+x,os.R_OK): + skip_makelinks=0 |
| 9 |
> |
| 10 |
> The logic here isn't obvious to me, could you clarify? |
| 11 |
|
| 12 |
makelinks is set to 1 by default when upgrading a package so that running |
| 13 |
ldconfig will update any shared lib links ... however, if the package doesnt |
| 14 |
install any libraries, then there's no point in running ldconfig |
| 15 |
|
| 16 |
> I've tried the |
| 17 |
> patch (against trunk revision 2564) and it seems that the skip_makelinks=0 |
| 18 |
> executes even when a package with no shared libraries is installed, making |
| 19 |
> the patch ineffective (I still get "Regenerating /etc/ld.so.cache" no |
| 20 |
> matter what). If I comment out the skip_makelinks=0 part then ldconfig |
| 21 |
> doesn't run unecessarily (as expected). |
| 22 |
|
| 23 |
that's because there's one small hunk missing from what i posted |
| 24 |
|
| 25 |
updated patch attached |
| 26 |
-mike |
Archives