Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@×××××.com>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [patch] dont run ldconfig unless libraries are actually installed
Date: Tue, 17 Jan 2006 00:52:28
Message-Id: 43CC3FCC.90604@gmail.com
In Reply to: [gentoo-portage-dev] [patch] dont run ldconfig unless libraries are actually installed by Mike Frysinger
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Mike Frysinger wrote:
5 > simple patch which gets rid of all the pointless calls to `ldconfig` when
6 > emerging packages that dont install libraries
7 >
8 > thoughts ?
9 > -mike
10
11 I like the idea (actually I've wanted to do away with the unnecessary "Regenerating /etc/ld.so.cache" for awhile now).
12
13 [...]
14 > - for x in specials["LDPATH"]+['/usr/lib','/lib']:
15 > + skip_makelinks=1
16 > + for x in portage_util.unique_array(specials["LDPATH"]+['/usr/lib','/usr/lib64','/usr/lib32','/lib','/lib64','/lib32']):
17 > + if makelinks and skip_makelinks and os.access(srcroot+x,os.R_OK):
18 > + skip_makelinks=0
19
20 The logic here isn't obvious to me, could you clarify? I've tried the patch (against trunk revision 2564) and it seems that the skip_makelinks=0 executes even when a package with no shared libraries is installed, making the patch ineffective (I still get "Regenerating /etc/ld.so.cache" no matter what). If I comment out the skip_makelinks=0 part then ldconfig doesn't run unecessarily (as expected).
21
22 Zac
23 -----BEGIN PGP SIGNATURE-----
24 Version: GnuPG v1.4.2 (GNU/Linux)
25
26 iD8DBQFDzD/M/ejvha5XGaMRApQ3AKCWP294lmk0BNoVjZtgvGdBSjunCgCglDhu
27 6ebM29qcAzGBBXTwLX5v/Bs=
28 =1NnI
29 -----END PGP SIGNATURE-----
30 --
31 gentoo-portage-dev@g.o mailing list

Replies