Re: [gentoo-portage-dev] [PATCH] xtermTitle: support st (simple terminal)

[Zac Medico]

On 12/03/2017 07:23 AM, Christoph Böhmwalder wrote:
> Currently users of suckless' simple terminal have to rely on ugly hacks
> like this in order to make portage display merging progress in the
> terminals title bar:
>
> alias emerge="TERM=xterm emerge"
>
> Officially support st by adding it to the list of legal terminals.
>
> Signed-off-by: Christoph Böhmwalder <christoph@×××××××××××.at>
> ---
>  pym/portage/output.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pym/portage/output.py b/pym/portage/output.py
> index 6d8c6324a..05aa7ba5c 100644
> --- a/pym/portage/output.py
> +++ b/pym/portage/output.py
> @@ -234,7 +234,7 @@ def nc_len(mystr):
>  	tmp = re.sub(esc_seq + "^m]+m", "", mystr);
>  	return len(tmp)
>
> -_legal_terms_re = re.compile(r'^(xterm|xterm-color|Eterm|aterm|rxvt|screen|kterm|rxvt-unicode|gnome|interix|tmux)')
> +_legal_terms_re = re.compile(r'^(xterm|xterm-color|Eterm|aterm|rxvt|screen|kterm|rxvt-unicode|gnome|interix|tmux|st)')
>  _disable_xtermTitle = None
>  _max_xtermTitle_len = 253

Your change will match any TERM value that starts with 'st', which seems
too loose. How about if we match st-256color instead?
-- 
Thanks,
Zac